Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 23, 2025


PR-Codex overview

This PR revamps the fiat onramp UI in the PayEmbed, introduces support for multi-hop onramp flows, and updates various components and functions related to fiat transactions.

Detailed summary

  • Renamed Top up to Fund Wallet in multiple places.
  • Removed FiatFlow and FiatStatusScreen components.
  • Added support for new fiat currencies: AUD and NZD.
  • Updated currency selection and icon rendering logic.
  • Enhanced OnRampScreen for better flow handling.
  • Refactored getFiatSymbol and related functions for improved currency management.
  • Implemented StepConnectorArrow for UI consistency in transaction steps.
  • Improved error handling and loading states in transaction processes.
  • Updated various hooks to streamline data fetching and state management.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2025

🦋 Changeset detected

Latest commit: 9fd1688

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:58pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:58pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:58pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:58pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:58pm

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Feb 23, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review February 23, 2025 13:22
@joaquim-verges joaquim-verges requested review from a team as code owners February 23, 2025 13:22
Copy link
Member Author

joaquim-verges commented Feb 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 334 ms (-12.99% 🔽) 1.3 s
thirdweb (cjs) 121.87 KB (0%) 2.5 s (0%) 1.1 s (+39.79% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 96 ms (+252.41% 🔺) 208 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 42 ms (+727.24% 🔺) 52 ms
thirdweb/react (minimal + tree-shaking) 19.31 KB (+0.1% 🔺) 387 ms (+0.1% 🔺) 63 ms (-55.04% 🔽) 449 ms

@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Enhance_fiat_onramp_with_multi-step_flow_and_currency_support branch from d8ff519 to a410abf Compare February 24, 2025 01:40
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Enhance_fiat_onramp_with_multi-step_flow_and_currency_support branch from a410abf to 54a9bb3 Compare February 24, 2025 01:52
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Enhance_fiat_onramp_with_multi-step_flow_and_currency_support branch from 54a9bb3 to ff9a3c0 Compare February 24, 2025 09:11
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Enhance_fiat_onramp_with_multi-step_flow_and_currency_support branch from cf463e0 to 3102a24 Compare February 24, 2025 11:24
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Enhance_fiat_onramp_with_multi-step_flow_and_currency_support branch 2 times, most recently from 33b97fb to 110d5fb Compare February 24, 2025 11:31
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Enhance_fiat_onramp_with_multi-step_flow_and_currency_support branch from 110d5fb to d7bbdb2 Compare February 24, 2025 12:03
@joaquim-verges joaquim-verges force-pushed the _SDK_feat_Enhance_fiat_onramp_with_multi-step_flow_and_currency_support branch from d7bbdb2 to 9fd1688 Compare February 24, 2025 22:50
@joaquim-verges joaquim-verges merged commit 15adec4 into main Feb 24, 2025
29 of 31 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_feat_Enhance_fiat_onramp_with_multi-step_flow_and_currency_support branch February 24, 2025 23:19
@joaquim-verges joaquim-verges mentioned this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants